feat: estimate transaction size in the FFI crate #81
+56
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in the FFI crate.
Yeah that's what the JS SDK does too. I think we keep the logic the same. |
|
Huh. Interesting. I'll make the change. |
…re in the encoded transaction
neilcampbell
approved these changes
May 16, 2025
| @@ -59,6 +59,12 @@ impl AssetTransferTransactionBuilder { | |||
| impl AlgorandMsgpack for Transaction {} | |||
| impl TransactionId for Transaction {} | |||
|
|
|||
| impl EstimateTransactionSize for Transaction { | |||
| fn estimate_size(&self) -> Result<usize, AlgoKitTransactError> { | |||
There was a problem hiding this comment.
Worth adding a simple test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought this code is common enough we might want it in core.
I am still missing a way to do it in the rust crate. After I do that, the FFI crate should only re-expose what's in the core crate.
Also, I haven't taken the approach of actually signing it as it is a slow operation. I decided to attach an invalid signature, encode, and get the size.
I've also seen a bunch of times just adding
75to the encoding length without a signature. I am assuming75comes up from the field name, the encoding and the signature length.What approach do we think is best?